Update Package.swift #153
Open
Update Package.swift #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there anything I can do to help with the failed checks? I have exactly this example with the correction running now in a private repo, talking to a local podman repository, responding to curl just fine. I can make it public if it will help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I believe the line
.package(path: "../.."),in thePackage.swiftof the Hummingbird example is vestigial from perhaps a previous version where it was just aPackage.swiftand amain.swift. If it is need explicitly for a container build, please mention in the docs because a regularswift buildto test the app locally doesn't work until it is removed.Modifications
removed the single line
.package(path: "../..")from thePackage.swiftin the Hummingbird example.Result
Example will now build to be tested pre-containerization test.
Test Plan
Don't believe change needs a test as the example already does not have tests.